exec_kunit.c 6.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. #include <kunit/test.h>
  3. struct bprm_stack_limits_result {
  4. struct linux_binprm bprm;
  5. int expected_rc;
  6. unsigned long expected_argmin;
  7. };
  8. static const struct bprm_stack_limits_result bprm_stack_limits_results[] = {
  9. /* Negative argc/envc counts produce -E2BIG */
  10. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  11. .argc = INT_MIN, .envc = INT_MIN }, .expected_rc = -E2BIG },
  12. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  13. .argc = 5, .envc = -1 }, .expected_rc = -E2BIG },
  14. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  15. .argc = -1, .envc = 10 }, .expected_rc = -E2BIG },
  16. /* The max value of argc or envc is MAX_ARG_STRINGS. */
  17. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  18. .argc = INT_MAX, .envc = INT_MAX }, .expected_rc = -E2BIG },
  19. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  20. .argc = MAX_ARG_STRINGS, .envc = MAX_ARG_STRINGS }, .expected_rc = -E2BIG },
  21. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  22. .argc = 0, .envc = MAX_ARG_STRINGS }, .expected_rc = -E2BIG },
  23. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  24. .argc = MAX_ARG_STRINGS, .envc = 0 }, .expected_rc = -E2BIG },
  25. /*
  26. * On 32-bit system these argc and envc counts, while likely impossible
  27. * to represent within the associated TASK_SIZE, could overflow the
  28. * limit calculation, and bypass the ptr_size <= limit check.
  29. */
  30. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ULONG_MAX,
  31. .argc = 0x20000001, .envc = 0x20000001 }, .expected_rc = -E2BIG },
  32. #ifdef CONFIG_MMU
  33. /* Make sure a pathological bprm->p doesn't cause an overflow. */
  34. { { .p = sizeof(void *), .rlim_stack.rlim_cur = ULONG_MAX,
  35. .argc = 10, .envc = 10 }, .expected_rc = -E2BIG },
  36. #endif
  37. /*
  38. * 0 rlim_stack will get raised to ARG_MAX. With 1 string pointer,
  39. * we should see p - ARG_MAX + sizeof(void *).
  40. */
  41. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  42. .argc = 1, .envc = 0 }, .expected_argmin = ULONG_MAX - ARG_MAX + sizeof(void *)},
  43. /* Validate that argc is always raised to a minimum of 1. */
  44. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  45. .argc = 0, .envc = 0 }, .expected_argmin = ULONG_MAX - ARG_MAX + sizeof(void *)},
  46. /*
  47. * 0 rlim_stack will get raised to ARG_MAX. With pointers filling ARG_MAX,
  48. * we should see -E2BIG. (Note argc is always raised to at least 1.)
  49. */
  50. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  51. .argc = ARG_MAX / sizeof(void *), .envc = 0 }, .expected_rc = -E2BIG },
  52. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  53. .argc = 0, .envc = ARG_MAX / sizeof(void *) - 1 }, .expected_rc = -E2BIG },
  54. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  55. .argc = ARG_MAX / sizeof(void *) + 1, .envc = 0 }, .expected_rc = -E2BIG },
  56. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  57. .argc = 0, .envc = ARG_MAX / sizeof(void *) }, .expected_rc = -E2BIG },
  58. /* And with one less, we see space for exactly 1 pointer. */
  59. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  60. .argc = (ARG_MAX / sizeof(void *)) - 1, .envc = 0 },
  61. .expected_argmin = ULONG_MAX - sizeof(void *) },
  62. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 0,
  63. .argc = 0, .envc = (ARG_MAX / sizeof(void *)) - 2, },
  64. .expected_argmin = ULONG_MAX - sizeof(void *) },
  65. /* If we raise rlim_stack / 4 to exactly ARG_MAX, nothing changes. */
  66. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  67. .argc = ARG_MAX / sizeof(void *), .envc = 0 }, .expected_rc = -E2BIG },
  68. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  69. .argc = 0, .envc = ARG_MAX / sizeof(void *) - 1 }, .expected_rc = -E2BIG },
  70. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  71. .argc = ARG_MAX / sizeof(void *) + 1, .envc = 0 }, .expected_rc = -E2BIG },
  72. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  73. .argc = 0, .envc = ARG_MAX / sizeof(void *) }, .expected_rc = -E2BIG },
  74. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  75. .argc = (ARG_MAX / sizeof(void *)) - 1, .envc = 0 },
  76. .expected_argmin = ULONG_MAX - sizeof(void *) },
  77. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = ARG_MAX * 4,
  78. .argc = 0, .envc = (ARG_MAX / sizeof(void *)) - 2, },
  79. .expected_argmin = ULONG_MAX - sizeof(void *) },
  80. /* But raising it another pointer * 4 will provide space for 1 more pointer. */
  81. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = (ARG_MAX + sizeof(void *)) * 4,
  82. .argc = ARG_MAX / sizeof(void *), .envc = 0 },
  83. .expected_argmin = ULONG_MAX - sizeof(void *) },
  84. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = (ARG_MAX + sizeof(void *)) * 4,
  85. .argc = 0, .envc = ARG_MAX / sizeof(void *) - 1 },
  86. .expected_argmin = ULONG_MAX - sizeof(void *) },
  87. /* Raising rlim_stack / 4 to _STK_LIM / 4 * 3 will see more space. */
  88. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * 3),
  89. .argc = 0, .envc = 0 },
  90. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  91. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * 3),
  92. .argc = 0, .envc = 0 },
  93. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  94. /* But raising it any further will see no increase. */
  95. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * 3 + sizeof(void *)),
  96. .argc = 0, .envc = 0 },
  97. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  98. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * + sizeof(void *)),
  99. .argc = 0, .envc = 0 },
  100. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  101. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * _STK_LIM,
  102. .argc = 0, .envc = 0 },
  103. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  104. { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * _STK_LIM,
  105. .argc = 0, .envc = 0 },
  106. .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
  107. };
  108. static void exec_test_bprm_stack_limits(struct kunit *test)
  109. {
  110. /* Double-check the constants. */
  111. KUNIT_EXPECT_EQ(test, _STK_LIM, SZ_8M);
  112. KUNIT_EXPECT_EQ(test, ARG_MAX, 32 * SZ_4K);
  113. KUNIT_EXPECT_EQ(test, MAX_ARG_STRINGS, 0x7FFFFFFF);
  114. for (int i = 0; i < ARRAY_SIZE(bprm_stack_limits_results); i++) {
  115. const struct bprm_stack_limits_result *result = &bprm_stack_limits_results[i];
  116. struct linux_binprm bprm = result->bprm;
  117. int rc;
  118. rc = bprm_stack_limits(&bprm);
  119. KUNIT_EXPECT_EQ_MSG(test, rc, result->expected_rc, "on loop %d", i);
  120. #ifdef CONFIG_MMU
  121. KUNIT_EXPECT_EQ_MSG(test, bprm.argmin, result->expected_argmin, "on loop %d", i);
  122. #endif
  123. }
  124. }
  125. static struct kunit_case exec_test_cases[] = {
  126. KUNIT_CASE(exec_test_bprm_stack_limits),
  127. {},
  128. };
  129. static struct kunit_suite exec_test_suite = {
  130. .name = "exec",
  131. .test_cases = exec_test_cases,
  132. };
  133. kunit_test_suite(exec_test_suite);