submitting-patches.txt 3.0 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374
  1. Submitting devicetree (DT) binding patches
  2. I. For patch submitters
  3. 0) Normal patch submission rules from Documentation/process/submitting-patches.rst
  4. applies.
  5. 1) The Documentation/ and include/dt-bindings/ portion of the patch should
  6. be a separate patch. The preferred subject prefix for binding patches is:
  7. "dt-bindings: <binding dir>: ..."
  8. The 80 characters of the subject are precious. It is recommended to not
  9. use "Documentation" or "doc" because that is implied. All bindings are
  10. docs. Repeating "binding" again should also be avoided.
  11. 2) Submit the entire series to the devicetree mailinglist at
  12. devicetree@vger.kernel.org
  13. and Cc: the DT maintainers. Use scripts/get_maintainer.pl to identify
  14. all of the DT maintainers.
  15. 3) The Documentation/ portion of the patch should come in the series before
  16. the code implementing the binding.
  17. 4) Any compatible strings used in a chip or board DTS file must be
  18. previously documented in the corresponding DT binding text file
  19. in Documentation/devicetree/bindings. This rule applies even if
  20. the Linux device driver does not yet match on the compatible
  21. string. [ checkpatch will emit warnings if this step is not
  22. followed as of commit bff5da4335256513497cc8c79f9a9d1665e09864
  23. ("checkpatch: add DT compatible string documentation checks"). ]
  24. 5) The wildcard "<chip>" may be used in compatible strings, as in
  25. the following example:
  26. - compatible: Must contain '"nvidia,<chip>-pcie",
  27. "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
  28. As in the above example, the known values of "<chip>" should be
  29. documented if it is used.
  30. 6) If a documented compatible string is not yet matched by the
  31. driver, the documentation should also include a compatible
  32. string that is matched by the driver (as in the "nvidia,tegra20-pcie"
  33. example above).
  34. II. For kernel maintainers
  35. 1) If you aren't comfortable reviewing a given binding, reply to it and ask
  36. the devicetree maintainers for guidance. This will help them prioritize
  37. which ones to review and which ones are ok to let go.
  38. 2) For driver (not subsystem) bindings: If you are comfortable with the
  39. binding, and it hasn't received an Acked-by from the devicetree
  40. maintainers after a few weeks, go ahead and take it.
  41. Subsystem bindings (anything affecting more than a single device)
  42. then getting a devicetree maintainer to review it is required.
  43. 3) For a series going though multiple trees, the binding patch should be
  44. kept with the driver using the binding.
  45. III. Notes
  46. 0) Please see ...bindings/ABI.txt for details regarding devicetree ABI.
  47. 1) This document is intended as a general familiarization with the process as
  48. decided at the 2013 Kernel Summit. When in doubt, the current word of the
  49. devicetree maintainers overrules this document. In that situation, a patch
  50. updating this document would be appreciated.