dwc3-qcom.c 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619
  1. // SPDX-License-Identifier: GPL-2.0
  2. /* Copyright (c) 2018, The Linux Foundation. All rights reserved.
  3. *
  4. * Inspired by dwc3-of-simple.c
  5. */
  6. #include <linux/io.h>
  7. #include <linux/of.h>
  8. #include <linux/clk.h>
  9. #include <linux/irq.h>
  10. #include <linux/clk-provider.h>
  11. #include <linux/module.h>
  12. #include <linux/kernel.h>
  13. #include <linux/extcon.h>
  14. #include <linux/of_platform.h>
  15. #include <linux/platform_device.h>
  16. #include <linux/phy/phy.h>
  17. #include <linux/usb/of.h>
  18. #include <linux/reset.h>
  19. #include <linux/iopoll.h>
  20. #include "core.h"
  21. /* USB QSCRATCH Hardware registers */
  22. #define QSCRATCH_HS_PHY_CTRL 0x10
  23. #define UTMI_OTG_VBUS_VALID BIT(20)
  24. #define SW_SESSVLD_SEL BIT(28)
  25. #define QSCRATCH_SS_PHY_CTRL 0x30
  26. #define LANE0_PWR_PRESENT BIT(24)
  27. #define QSCRATCH_GENERAL_CFG 0x08
  28. #define PIPE_UTMI_CLK_SEL BIT(0)
  29. #define PIPE3_PHYSTATUS_SW BIT(3)
  30. #define PIPE_UTMI_CLK_DIS BIT(8)
  31. #define PWR_EVNT_IRQ_STAT_REG 0x58
  32. #define PWR_EVNT_LPM_IN_L2_MASK BIT(4)
  33. #define PWR_EVNT_LPM_OUT_L2_MASK BIT(5)
  34. struct dwc3_qcom {
  35. struct device *dev;
  36. void __iomem *qscratch_base;
  37. struct platform_device *dwc3;
  38. struct clk **clks;
  39. int num_clocks;
  40. struct reset_control *resets;
  41. int hs_phy_irq;
  42. int dp_hs_phy_irq;
  43. int dm_hs_phy_irq;
  44. int ss_phy_irq;
  45. struct extcon_dev *edev;
  46. struct extcon_dev *host_edev;
  47. struct notifier_block vbus_nb;
  48. struct notifier_block host_nb;
  49. enum usb_dr_mode mode;
  50. bool is_suspended;
  51. bool pm_suspended;
  52. };
  53. static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val)
  54. {
  55. u32 reg;
  56. reg = readl(base + offset);
  57. reg |= val;
  58. writel(reg, base + offset);
  59. /* ensure that above write is through */
  60. readl(base + offset);
  61. }
  62. static inline void dwc3_qcom_clrbits(void __iomem *base, u32 offset, u32 val)
  63. {
  64. u32 reg;
  65. reg = readl(base + offset);
  66. reg &= ~val;
  67. writel(reg, base + offset);
  68. /* ensure that above write is through */
  69. readl(base + offset);
  70. }
  71. static void dwc3_qcom_vbus_overrride_enable(struct dwc3_qcom *qcom, bool enable)
  72. {
  73. if (enable) {
  74. dwc3_qcom_setbits(qcom->qscratch_base, QSCRATCH_SS_PHY_CTRL,
  75. LANE0_PWR_PRESENT);
  76. dwc3_qcom_setbits(qcom->qscratch_base, QSCRATCH_HS_PHY_CTRL,
  77. UTMI_OTG_VBUS_VALID | SW_SESSVLD_SEL);
  78. } else {
  79. dwc3_qcom_clrbits(qcom->qscratch_base, QSCRATCH_SS_PHY_CTRL,
  80. LANE0_PWR_PRESENT);
  81. dwc3_qcom_clrbits(qcom->qscratch_base, QSCRATCH_HS_PHY_CTRL,
  82. UTMI_OTG_VBUS_VALID | SW_SESSVLD_SEL);
  83. }
  84. }
  85. static int dwc3_qcom_vbus_notifier(struct notifier_block *nb,
  86. unsigned long event, void *ptr)
  87. {
  88. struct dwc3_qcom *qcom = container_of(nb, struct dwc3_qcom, vbus_nb);
  89. /* enable vbus override for device mode */
  90. dwc3_qcom_vbus_overrride_enable(qcom, event);
  91. qcom->mode = event ? USB_DR_MODE_PERIPHERAL : USB_DR_MODE_HOST;
  92. return NOTIFY_DONE;
  93. }
  94. static int dwc3_qcom_host_notifier(struct notifier_block *nb,
  95. unsigned long event, void *ptr)
  96. {
  97. struct dwc3_qcom *qcom = container_of(nb, struct dwc3_qcom, host_nb);
  98. /* disable vbus override in host mode */
  99. dwc3_qcom_vbus_overrride_enable(qcom, !event);
  100. qcom->mode = event ? USB_DR_MODE_HOST : USB_DR_MODE_PERIPHERAL;
  101. return NOTIFY_DONE;
  102. }
  103. static int dwc3_qcom_register_extcon(struct dwc3_qcom *qcom)
  104. {
  105. struct device *dev = qcom->dev;
  106. struct extcon_dev *host_edev;
  107. int ret;
  108. if (!of_property_read_bool(dev->of_node, "extcon"))
  109. return 0;
  110. qcom->edev = extcon_get_edev_by_phandle(dev, 0);
  111. if (IS_ERR(qcom->edev))
  112. return PTR_ERR(qcom->edev);
  113. qcom->vbus_nb.notifier_call = dwc3_qcom_vbus_notifier;
  114. qcom->host_edev = extcon_get_edev_by_phandle(dev, 1);
  115. if (IS_ERR(qcom->host_edev))
  116. qcom->host_edev = NULL;
  117. ret = devm_extcon_register_notifier(dev, qcom->edev, EXTCON_USB,
  118. &qcom->vbus_nb);
  119. if (ret < 0) {
  120. dev_err(dev, "VBUS notifier register failed\n");
  121. return ret;
  122. }
  123. if (qcom->host_edev)
  124. host_edev = qcom->host_edev;
  125. else
  126. host_edev = qcom->edev;
  127. qcom->host_nb.notifier_call = dwc3_qcom_host_notifier;
  128. ret = devm_extcon_register_notifier(dev, host_edev, EXTCON_USB_HOST,
  129. &qcom->host_nb);
  130. if (ret < 0) {
  131. dev_err(dev, "Host notifier register failed\n");
  132. return ret;
  133. }
  134. /* Update initial VBUS override based on extcon state */
  135. if (extcon_get_state(qcom->edev, EXTCON_USB) ||
  136. !extcon_get_state(host_edev, EXTCON_USB_HOST))
  137. dwc3_qcom_vbus_notifier(&qcom->vbus_nb, true, qcom->edev);
  138. else
  139. dwc3_qcom_vbus_notifier(&qcom->vbus_nb, false, qcom->edev);
  140. return 0;
  141. }
  142. static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom)
  143. {
  144. if (qcom->hs_phy_irq) {
  145. disable_irq_wake(qcom->hs_phy_irq);
  146. disable_irq_nosync(qcom->hs_phy_irq);
  147. }
  148. if (qcom->dp_hs_phy_irq) {
  149. disable_irq_wake(qcom->dp_hs_phy_irq);
  150. disable_irq_nosync(qcom->dp_hs_phy_irq);
  151. }
  152. if (qcom->dm_hs_phy_irq) {
  153. disable_irq_wake(qcom->dm_hs_phy_irq);
  154. disable_irq_nosync(qcom->dm_hs_phy_irq);
  155. }
  156. if (qcom->ss_phy_irq) {
  157. disable_irq_wake(qcom->ss_phy_irq);
  158. disable_irq_nosync(qcom->ss_phy_irq);
  159. }
  160. }
  161. static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom)
  162. {
  163. if (qcom->hs_phy_irq) {
  164. enable_irq(qcom->hs_phy_irq);
  165. enable_irq_wake(qcom->hs_phy_irq);
  166. }
  167. if (qcom->dp_hs_phy_irq) {
  168. enable_irq(qcom->dp_hs_phy_irq);
  169. enable_irq_wake(qcom->dp_hs_phy_irq);
  170. }
  171. if (qcom->dm_hs_phy_irq) {
  172. enable_irq(qcom->dm_hs_phy_irq);
  173. enable_irq_wake(qcom->dm_hs_phy_irq);
  174. }
  175. if (qcom->ss_phy_irq) {
  176. enable_irq(qcom->ss_phy_irq);
  177. enable_irq_wake(qcom->ss_phy_irq);
  178. }
  179. }
  180. static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
  181. {
  182. u32 val;
  183. int i;
  184. if (qcom->is_suspended)
  185. return 0;
  186. val = readl(qcom->qscratch_base + PWR_EVNT_IRQ_STAT_REG);
  187. if (!(val & PWR_EVNT_LPM_IN_L2_MASK))
  188. dev_err(qcom->dev, "HS-PHY not in L2\n");
  189. for (i = qcom->num_clocks - 1; i >= 0; i--)
  190. clk_disable_unprepare(qcom->clks[i]);
  191. if (device_may_wakeup(qcom->dev))
  192. dwc3_qcom_enable_interrupts(qcom);
  193. qcom->is_suspended = true;
  194. return 0;
  195. }
  196. static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
  197. {
  198. int ret;
  199. int i;
  200. if (!qcom->is_suspended)
  201. return 0;
  202. if (device_may_wakeup(qcom->dev))
  203. dwc3_qcom_disable_interrupts(qcom);
  204. for (i = 0; i < qcom->num_clocks; i++) {
  205. ret = clk_prepare_enable(qcom->clks[i]);
  206. if (ret < 0) {
  207. while (--i >= 0)
  208. clk_disable_unprepare(qcom->clks[i]);
  209. return ret;
  210. }
  211. }
  212. /* Clear existing events from PHY related to L2 in/out */
  213. dwc3_qcom_setbits(qcom->qscratch_base, PWR_EVNT_IRQ_STAT_REG,
  214. PWR_EVNT_LPM_IN_L2_MASK | PWR_EVNT_LPM_OUT_L2_MASK);
  215. qcom->is_suspended = false;
  216. return 0;
  217. }
  218. static irqreturn_t qcom_dwc3_resume_irq(int irq, void *data)
  219. {
  220. struct dwc3_qcom *qcom = data;
  221. struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
  222. /* If pm_suspended then let pm_resume take care of resuming h/w */
  223. if (qcom->pm_suspended)
  224. return IRQ_HANDLED;
  225. if (dwc->xhci)
  226. pm_runtime_resume(&dwc->xhci->dev);
  227. return IRQ_HANDLED;
  228. }
  229. static void dwc3_qcom_select_utmi_clk(struct dwc3_qcom *qcom)
  230. {
  231. /* Configure dwc3 to use UTMI clock as PIPE clock not present */
  232. dwc3_qcom_setbits(qcom->qscratch_base, QSCRATCH_GENERAL_CFG,
  233. PIPE_UTMI_CLK_DIS);
  234. usleep_range(100, 1000);
  235. dwc3_qcom_setbits(qcom->qscratch_base, QSCRATCH_GENERAL_CFG,
  236. PIPE_UTMI_CLK_SEL | PIPE3_PHYSTATUS_SW);
  237. usleep_range(100, 1000);
  238. dwc3_qcom_clrbits(qcom->qscratch_base, QSCRATCH_GENERAL_CFG,
  239. PIPE_UTMI_CLK_DIS);
  240. }
  241. static int dwc3_qcom_setup_irq(struct platform_device *pdev)
  242. {
  243. struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
  244. int irq, ret;
  245. irq = platform_get_irq_byname(pdev, "hs_phy_irq");
  246. if (irq > 0) {
  247. /* Keep wakeup interrupts disabled until suspend */
  248. irq_set_status_flags(irq, IRQ_NOAUTOEN);
  249. ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
  250. qcom_dwc3_resume_irq,
  251. IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
  252. "qcom_dwc3 HS", qcom);
  253. if (ret) {
  254. dev_err(qcom->dev, "hs_phy_irq failed: %d\n", ret);
  255. return ret;
  256. }
  257. qcom->hs_phy_irq = irq;
  258. }
  259. irq = platform_get_irq_byname(pdev, "dp_hs_phy_irq");
  260. if (irq > 0) {
  261. irq_set_status_flags(irq, IRQ_NOAUTOEN);
  262. ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
  263. qcom_dwc3_resume_irq,
  264. IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
  265. "qcom_dwc3 DP_HS", qcom);
  266. if (ret) {
  267. dev_err(qcom->dev, "dp_hs_phy_irq failed: %d\n", ret);
  268. return ret;
  269. }
  270. qcom->dp_hs_phy_irq = irq;
  271. }
  272. irq = platform_get_irq_byname(pdev, "dm_hs_phy_irq");
  273. if (irq > 0) {
  274. irq_set_status_flags(irq, IRQ_NOAUTOEN);
  275. ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
  276. qcom_dwc3_resume_irq,
  277. IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
  278. "qcom_dwc3 DM_HS", qcom);
  279. if (ret) {
  280. dev_err(qcom->dev, "dm_hs_phy_irq failed: %d\n", ret);
  281. return ret;
  282. }
  283. qcom->dm_hs_phy_irq = irq;
  284. }
  285. irq = platform_get_irq_byname(pdev, "ss_phy_irq");
  286. if (irq > 0) {
  287. irq_set_status_flags(irq, IRQ_NOAUTOEN);
  288. ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
  289. qcom_dwc3_resume_irq,
  290. IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
  291. "qcom_dwc3 SS", qcom);
  292. if (ret) {
  293. dev_err(qcom->dev, "ss_phy_irq failed: %d\n", ret);
  294. return ret;
  295. }
  296. qcom->ss_phy_irq = irq;
  297. }
  298. return 0;
  299. }
  300. static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count)
  301. {
  302. struct device *dev = qcom->dev;
  303. struct device_node *np = dev->of_node;
  304. int i;
  305. qcom->num_clocks = count;
  306. if (!count)
  307. return 0;
  308. qcom->clks = devm_kcalloc(dev, qcom->num_clocks,
  309. sizeof(struct clk *), GFP_KERNEL);
  310. if (!qcom->clks)
  311. return -ENOMEM;
  312. for (i = 0; i < qcom->num_clocks; i++) {
  313. struct clk *clk;
  314. int ret;
  315. clk = of_clk_get(np, i);
  316. if (IS_ERR(clk)) {
  317. while (--i >= 0)
  318. clk_put(qcom->clks[i]);
  319. return PTR_ERR(clk);
  320. }
  321. ret = clk_prepare_enable(clk);
  322. if (ret < 0) {
  323. while (--i >= 0) {
  324. clk_disable_unprepare(qcom->clks[i]);
  325. clk_put(qcom->clks[i]);
  326. }
  327. clk_put(clk);
  328. return ret;
  329. }
  330. qcom->clks[i] = clk;
  331. }
  332. return 0;
  333. }
  334. static int dwc3_qcom_probe(struct platform_device *pdev)
  335. {
  336. struct device_node *np = pdev->dev.of_node, *dwc3_np;
  337. struct device *dev = &pdev->dev;
  338. struct dwc3_qcom *qcom;
  339. struct resource *res;
  340. int ret, i;
  341. bool ignore_pipe_clk;
  342. qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL);
  343. if (!qcom)
  344. return -ENOMEM;
  345. platform_set_drvdata(pdev, qcom);
  346. qcom->dev = &pdev->dev;
  347. qcom->resets = devm_reset_control_array_get_optional_exclusive(dev);
  348. if (IS_ERR(qcom->resets)) {
  349. ret = PTR_ERR(qcom->resets);
  350. dev_err(&pdev->dev, "failed to get resets, err=%d\n", ret);
  351. return ret;
  352. }
  353. ret = reset_control_assert(qcom->resets);
  354. if (ret) {
  355. dev_err(&pdev->dev, "failed to assert resets, err=%d\n", ret);
  356. return ret;
  357. }
  358. usleep_range(10, 1000);
  359. ret = reset_control_deassert(qcom->resets);
  360. if (ret) {
  361. dev_err(&pdev->dev, "failed to deassert resets, err=%d\n", ret);
  362. goto reset_assert;
  363. }
  364. ret = dwc3_qcom_clk_init(qcom, of_count_phandle_with_args(np,
  365. "clocks", "#clock-cells"));
  366. if (ret) {
  367. dev_err(dev, "failed to get clocks\n");
  368. goto reset_assert;
  369. }
  370. res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  371. qcom->qscratch_base = devm_ioremap_resource(dev, res);
  372. if (IS_ERR(qcom->qscratch_base)) {
  373. dev_err(dev, "failed to map qscratch, err=%d\n", ret);
  374. ret = PTR_ERR(qcom->qscratch_base);
  375. goto clk_disable;
  376. }
  377. ret = dwc3_qcom_setup_irq(pdev);
  378. if (ret)
  379. goto clk_disable;
  380. dwc3_np = of_get_child_by_name(np, "dwc3");
  381. if (!dwc3_np) {
  382. dev_err(dev, "failed to find dwc3 core child\n");
  383. ret = -ENODEV;
  384. goto clk_disable;
  385. }
  386. /*
  387. * Disable pipe_clk requirement if specified. Used when dwc3
  388. * operates without SSPHY and only HS/FS/LS modes are supported.
  389. */
  390. ignore_pipe_clk = device_property_read_bool(dev,
  391. "qcom,select-utmi-as-pipe-clk");
  392. if (ignore_pipe_clk)
  393. dwc3_qcom_select_utmi_clk(qcom);
  394. ret = of_platform_populate(np, NULL, NULL, dev);
  395. if (ret) {
  396. dev_err(dev, "failed to register dwc3 core - %d\n", ret);
  397. goto clk_disable;
  398. }
  399. qcom->dwc3 = of_find_device_by_node(dwc3_np);
  400. if (!qcom->dwc3) {
  401. dev_err(&pdev->dev, "failed to get dwc3 platform device\n");
  402. ret = -ENODEV;
  403. goto depopulate;
  404. }
  405. qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);
  406. /* enable vbus override for device mode */
  407. if (qcom->mode == USB_DR_MODE_PERIPHERAL)
  408. dwc3_qcom_vbus_overrride_enable(qcom, true);
  409. /* register extcon to override sw_vbus on Vbus change later */
  410. ret = dwc3_qcom_register_extcon(qcom);
  411. if (ret)
  412. goto depopulate;
  413. device_init_wakeup(&pdev->dev, 1);
  414. qcom->is_suspended = false;
  415. pm_runtime_set_active(dev);
  416. pm_runtime_enable(dev);
  417. pm_runtime_forbid(dev);
  418. return 0;
  419. depopulate:
  420. of_platform_depopulate(&pdev->dev);
  421. clk_disable:
  422. for (i = qcom->num_clocks - 1; i >= 0; i--) {
  423. clk_disable_unprepare(qcom->clks[i]);
  424. clk_put(qcom->clks[i]);
  425. }
  426. reset_assert:
  427. reset_control_assert(qcom->resets);
  428. return ret;
  429. }
  430. static int dwc3_qcom_remove(struct platform_device *pdev)
  431. {
  432. struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
  433. struct device *dev = &pdev->dev;
  434. int i;
  435. of_platform_depopulate(dev);
  436. for (i = qcom->num_clocks - 1; i >= 0; i--) {
  437. clk_disable_unprepare(qcom->clks[i]);
  438. clk_put(qcom->clks[i]);
  439. }
  440. qcom->num_clocks = 0;
  441. reset_control_assert(qcom->resets);
  442. pm_runtime_allow(dev);
  443. pm_runtime_disable(dev);
  444. return 0;
  445. }
  446. static int __maybe_unused dwc3_qcom_pm_suspend(struct device *dev)
  447. {
  448. struct dwc3_qcom *qcom = dev_get_drvdata(dev);
  449. int ret = 0;
  450. ret = dwc3_qcom_suspend(qcom);
  451. if (!ret)
  452. qcom->pm_suspended = true;
  453. return ret;
  454. }
  455. static int __maybe_unused dwc3_qcom_pm_resume(struct device *dev)
  456. {
  457. struct dwc3_qcom *qcom = dev_get_drvdata(dev);
  458. int ret;
  459. ret = dwc3_qcom_resume(qcom);
  460. if (!ret)
  461. qcom->pm_suspended = false;
  462. return ret;
  463. }
  464. static int __maybe_unused dwc3_qcom_runtime_suspend(struct device *dev)
  465. {
  466. struct dwc3_qcom *qcom = dev_get_drvdata(dev);
  467. return dwc3_qcom_suspend(qcom);
  468. }
  469. static int __maybe_unused dwc3_qcom_runtime_resume(struct device *dev)
  470. {
  471. struct dwc3_qcom *qcom = dev_get_drvdata(dev);
  472. return dwc3_qcom_resume(qcom);
  473. }
  474. static const struct dev_pm_ops dwc3_qcom_dev_pm_ops = {
  475. SET_SYSTEM_SLEEP_PM_OPS(dwc3_qcom_pm_suspend, dwc3_qcom_pm_resume)
  476. SET_RUNTIME_PM_OPS(dwc3_qcom_runtime_suspend, dwc3_qcom_runtime_resume,
  477. NULL)
  478. };
  479. static const struct of_device_id dwc3_qcom_of_match[] = {
  480. { .compatible = "qcom,dwc3" },
  481. { .compatible = "qcom,msm8996-dwc3" },
  482. { .compatible = "qcom,sdm845-dwc3" },
  483. { }
  484. };
  485. MODULE_DEVICE_TABLE(of, dwc3_qcom_of_match);
  486. static struct platform_driver dwc3_qcom_driver = {
  487. .probe = dwc3_qcom_probe,
  488. .remove = dwc3_qcom_remove,
  489. .driver = {
  490. .name = "dwc3-qcom",
  491. .pm = &dwc3_qcom_dev_pm_ops,
  492. .of_match_table = dwc3_qcom_of_match,
  493. },
  494. };
  495. module_platform_driver(dwc3_qcom_driver);
  496. MODULE_LICENSE("GPL v2");
  497. MODULE_DESCRIPTION("DesignWare DWC3 QCOM Glue Driver");