intel_breadcrumbs.c 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898
  1. /*
  2. * Copyright © 2015 Intel Corporation
  3. *
  4. * Permission is hereby granted, free of charge, to any person obtaining a
  5. * copy of this software and associated documentation files (the "Software"),
  6. * to deal in the Software without restriction, including without limitation
  7. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  8. * and/or sell copies of the Software, and to permit persons to whom the
  9. * Software is furnished to do so, subject to the following conditions:
  10. *
  11. * The above copyright notice and this permission notice (including the next
  12. * paragraph) shall be included in all copies or substantial portions of the
  13. * Software.
  14. *
  15. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  18. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20. * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21. * IN THE SOFTWARE.
  22. *
  23. */
  24. #include <linux/kthread.h>
  25. #include <uapi/linux/sched/types.h>
  26. #include "i915_drv.h"
  27. #ifdef CONFIG_SMP
  28. #define task_asleep(tsk) ((tsk)->state & TASK_NORMAL && !(tsk)->on_cpu)
  29. #else
  30. #define task_asleep(tsk) ((tsk)->state & TASK_NORMAL)
  31. #endif
  32. static unsigned int __intel_breadcrumbs_wakeup(struct intel_breadcrumbs *b)
  33. {
  34. struct intel_wait *wait;
  35. unsigned int result = 0;
  36. lockdep_assert_held(&b->irq_lock);
  37. wait = b->irq_wait;
  38. if (wait) {
  39. /*
  40. * N.B. Since task_asleep() and ttwu are not atomic, the
  41. * waiter may actually go to sleep after the check, causing
  42. * us to suppress a valid wakeup. We prefer to reduce the
  43. * number of false positive missed_breadcrumb() warnings
  44. * at the expense of a few false negatives, as it it easy
  45. * to trigger a false positive under heavy load. Enough
  46. * signal should remain from genuine missed_breadcrumb()
  47. * for us to detect in CI.
  48. */
  49. bool was_asleep = task_asleep(wait->tsk);
  50. result = ENGINE_WAKEUP_WAITER;
  51. if (wake_up_process(wait->tsk) && was_asleep)
  52. result |= ENGINE_WAKEUP_ASLEEP;
  53. }
  54. return result;
  55. }
  56. unsigned int intel_engine_wakeup(struct intel_engine_cs *engine)
  57. {
  58. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  59. unsigned long flags;
  60. unsigned int result;
  61. spin_lock_irqsave(&b->irq_lock, flags);
  62. result = __intel_breadcrumbs_wakeup(b);
  63. spin_unlock_irqrestore(&b->irq_lock, flags);
  64. return result;
  65. }
  66. static unsigned long wait_timeout(void)
  67. {
  68. return round_jiffies_up(jiffies + DRM_I915_HANGCHECK_JIFFIES);
  69. }
  70. static noinline void missed_breadcrumb(struct intel_engine_cs *engine)
  71. {
  72. if (GEM_SHOW_DEBUG()) {
  73. struct drm_printer p = drm_debug_printer(__func__);
  74. intel_engine_dump(engine, &p,
  75. "%s missed breadcrumb at %pS\n",
  76. engine->name, __builtin_return_address(0));
  77. }
  78. set_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings);
  79. }
  80. static void intel_breadcrumbs_hangcheck(struct timer_list *t)
  81. {
  82. struct intel_engine_cs *engine =
  83. from_timer(engine, t, breadcrumbs.hangcheck);
  84. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  85. unsigned int irq_count;
  86. if (!b->irq_armed)
  87. return;
  88. irq_count = READ_ONCE(b->irq_count);
  89. if (b->hangcheck_interrupts != irq_count) {
  90. b->hangcheck_interrupts = irq_count;
  91. mod_timer(&b->hangcheck, wait_timeout());
  92. return;
  93. }
  94. /* We keep the hangcheck timer alive until we disarm the irq, even
  95. * if there are no waiters at present.
  96. *
  97. * If the waiter was currently running, assume it hasn't had a chance
  98. * to process the pending interrupt (e.g, low priority task on a loaded
  99. * system) and wait until it sleeps before declaring a missed interrupt.
  100. *
  101. * If the waiter was asleep (and not even pending a wakeup), then we
  102. * must have missed an interrupt as the GPU has stopped advancing
  103. * but we still have a waiter. Assuming all batches complete within
  104. * DRM_I915_HANGCHECK_JIFFIES [1.5s]!
  105. */
  106. if (intel_engine_wakeup(engine) & ENGINE_WAKEUP_ASLEEP) {
  107. missed_breadcrumb(engine);
  108. mod_timer(&b->fake_irq, jiffies + 1);
  109. } else {
  110. mod_timer(&b->hangcheck, wait_timeout());
  111. }
  112. }
  113. static void intel_breadcrumbs_fake_irq(struct timer_list *t)
  114. {
  115. struct intel_engine_cs *engine =
  116. from_timer(engine, t, breadcrumbs.fake_irq);
  117. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  118. /*
  119. * The timer persists in case we cannot enable interrupts,
  120. * or if we have previously seen seqno/interrupt incoherency
  121. * ("missed interrupt" syndrome, better known as a "missed breadcrumb").
  122. * Here the worker will wake up every jiffie in order to kick the
  123. * oldest waiter to do the coherent seqno check.
  124. */
  125. spin_lock_irq(&b->irq_lock);
  126. if (b->irq_armed && !__intel_breadcrumbs_wakeup(b))
  127. __intel_engine_disarm_breadcrumbs(engine);
  128. spin_unlock_irq(&b->irq_lock);
  129. if (!b->irq_armed)
  130. return;
  131. /* If the user has disabled the fake-irq, restore the hangchecking */
  132. if (!test_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings)) {
  133. mod_timer(&b->hangcheck, wait_timeout());
  134. return;
  135. }
  136. mod_timer(&b->fake_irq, jiffies + 1);
  137. }
  138. static void irq_enable(struct intel_engine_cs *engine)
  139. {
  140. /*
  141. * FIXME: Ideally we want this on the API boundary, but for the
  142. * sake of testing with mock breadcrumbs (no HW so unable to
  143. * enable irqs) we place it deep within the bowels, at the point
  144. * of no return.
  145. */
  146. GEM_BUG_ON(!intel_irqs_enabled(engine->i915));
  147. /* Enabling the IRQ may miss the generation of the interrupt, but
  148. * we still need to force the barrier before reading the seqno,
  149. * just in case.
  150. */
  151. set_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted);
  152. /* Caller disables interrupts */
  153. if (engine->irq_enable) {
  154. spin_lock(&engine->i915->irq_lock);
  155. engine->irq_enable(engine);
  156. spin_unlock(&engine->i915->irq_lock);
  157. }
  158. }
  159. static void irq_disable(struct intel_engine_cs *engine)
  160. {
  161. /* Caller disables interrupts */
  162. if (engine->irq_disable) {
  163. spin_lock(&engine->i915->irq_lock);
  164. engine->irq_disable(engine);
  165. spin_unlock(&engine->i915->irq_lock);
  166. }
  167. }
  168. void __intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine)
  169. {
  170. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  171. lockdep_assert_held(&b->irq_lock);
  172. GEM_BUG_ON(b->irq_wait);
  173. GEM_BUG_ON(!b->irq_armed);
  174. GEM_BUG_ON(!b->irq_enabled);
  175. if (!--b->irq_enabled)
  176. irq_disable(engine);
  177. b->irq_armed = false;
  178. }
  179. void intel_engine_pin_breadcrumbs_irq(struct intel_engine_cs *engine)
  180. {
  181. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  182. spin_lock_irq(&b->irq_lock);
  183. if (!b->irq_enabled++)
  184. irq_enable(engine);
  185. GEM_BUG_ON(!b->irq_enabled); /* no overflow! */
  186. spin_unlock_irq(&b->irq_lock);
  187. }
  188. void intel_engine_unpin_breadcrumbs_irq(struct intel_engine_cs *engine)
  189. {
  190. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  191. spin_lock_irq(&b->irq_lock);
  192. GEM_BUG_ON(!b->irq_enabled); /* no underflow! */
  193. if (!--b->irq_enabled)
  194. irq_disable(engine);
  195. spin_unlock_irq(&b->irq_lock);
  196. }
  197. void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine)
  198. {
  199. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  200. struct intel_wait *wait, *n;
  201. if (!b->irq_armed)
  202. return;
  203. /*
  204. * We only disarm the irq when we are idle (all requests completed),
  205. * so if the bottom-half remains asleep, it missed the request
  206. * completion.
  207. */
  208. if (intel_engine_wakeup(engine) & ENGINE_WAKEUP_ASLEEP)
  209. missed_breadcrumb(engine);
  210. spin_lock_irq(&b->rb_lock);
  211. spin_lock(&b->irq_lock);
  212. b->irq_wait = NULL;
  213. if (b->irq_armed)
  214. __intel_engine_disarm_breadcrumbs(engine);
  215. spin_unlock(&b->irq_lock);
  216. rbtree_postorder_for_each_entry_safe(wait, n, &b->waiters, node) {
  217. GEM_BUG_ON(!i915_seqno_passed(intel_engine_get_seqno(engine),
  218. wait->seqno));
  219. RB_CLEAR_NODE(&wait->node);
  220. wake_up_process(wait->tsk);
  221. }
  222. b->waiters = RB_ROOT;
  223. spin_unlock_irq(&b->rb_lock);
  224. }
  225. static bool use_fake_irq(const struct intel_breadcrumbs *b)
  226. {
  227. const struct intel_engine_cs *engine =
  228. container_of(b, struct intel_engine_cs, breadcrumbs);
  229. if (!test_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings))
  230. return false;
  231. /*
  232. * Only start with the heavy weight fake irq timer if we have not
  233. * seen any interrupts since enabling it the first time. If the
  234. * interrupts are still arriving, it means we made a mistake in our
  235. * engine->seqno_barrier(), a timing error that should be transient
  236. * and unlikely to reoccur.
  237. */
  238. return READ_ONCE(b->irq_count) == b->hangcheck_interrupts;
  239. }
  240. static void enable_fake_irq(struct intel_breadcrumbs *b)
  241. {
  242. /* Ensure we never sleep indefinitely */
  243. if (!b->irq_enabled || use_fake_irq(b))
  244. mod_timer(&b->fake_irq, jiffies + 1);
  245. else
  246. mod_timer(&b->hangcheck, wait_timeout());
  247. }
  248. static bool __intel_breadcrumbs_enable_irq(struct intel_breadcrumbs *b)
  249. {
  250. struct intel_engine_cs *engine =
  251. container_of(b, struct intel_engine_cs, breadcrumbs);
  252. struct drm_i915_private *i915 = engine->i915;
  253. bool enabled;
  254. lockdep_assert_held(&b->irq_lock);
  255. if (b->irq_armed)
  256. return false;
  257. /* The breadcrumb irq will be disarmed on the interrupt after the
  258. * waiters are signaled. This gives us a single interrupt window in
  259. * which we can add a new waiter and avoid the cost of re-enabling
  260. * the irq.
  261. */
  262. b->irq_armed = true;
  263. if (I915_SELFTEST_ONLY(b->mock)) {
  264. /* For our mock objects we want to avoid interaction
  265. * with the real hardware (which is not set up). So
  266. * we simply pretend we have enabled the powerwell
  267. * and the irq, and leave it up to the mock
  268. * implementation to call intel_engine_wakeup()
  269. * itself when it wants to simulate a user interrupt,
  270. */
  271. return true;
  272. }
  273. /* Since we are waiting on a request, the GPU should be busy
  274. * and should have its own rpm reference. This is tracked
  275. * by i915->gt.awake, we can forgo holding our own wakref
  276. * for the interrupt as before i915->gt.awake is released (when
  277. * the driver is idle) we disarm the breadcrumbs.
  278. */
  279. /* No interrupts? Kick the waiter every jiffie! */
  280. enabled = false;
  281. if (!b->irq_enabled++ &&
  282. !test_bit(engine->id, &i915->gpu_error.test_irq_rings)) {
  283. irq_enable(engine);
  284. enabled = true;
  285. }
  286. enable_fake_irq(b);
  287. return enabled;
  288. }
  289. static inline struct intel_wait *to_wait(struct rb_node *node)
  290. {
  291. return rb_entry(node, struct intel_wait, node);
  292. }
  293. static inline void __intel_breadcrumbs_finish(struct intel_breadcrumbs *b,
  294. struct intel_wait *wait)
  295. {
  296. lockdep_assert_held(&b->rb_lock);
  297. GEM_BUG_ON(b->irq_wait == wait);
  298. /*
  299. * This request is completed, so remove it from the tree, mark it as
  300. * complete, and *then* wake up the associated task. N.B. when the
  301. * task wakes up, it will find the empty rb_node, discern that it
  302. * has already been removed from the tree and skip the serialisation
  303. * of the b->rb_lock and b->irq_lock. This means that the destruction
  304. * of the intel_wait is not serialised with the interrupt handler
  305. * by the waiter - it must instead be serialised by the caller.
  306. */
  307. rb_erase(&wait->node, &b->waiters);
  308. RB_CLEAR_NODE(&wait->node);
  309. if (wait->tsk->state != TASK_RUNNING)
  310. wake_up_process(wait->tsk); /* implicit smp_wmb() */
  311. }
  312. static inline void __intel_breadcrumbs_next(struct intel_engine_cs *engine,
  313. struct rb_node *next)
  314. {
  315. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  316. spin_lock(&b->irq_lock);
  317. GEM_BUG_ON(!b->irq_armed);
  318. GEM_BUG_ON(!b->irq_wait);
  319. b->irq_wait = to_wait(next);
  320. spin_unlock(&b->irq_lock);
  321. /* We always wake up the next waiter that takes over as the bottom-half
  322. * as we may delegate not only the irq-seqno barrier to the next waiter
  323. * but also the task of waking up concurrent waiters.
  324. */
  325. if (next)
  326. wake_up_process(to_wait(next)->tsk);
  327. }
  328. static bool __intel_engine_add_wait(struct intel_engine_cs *engine,
  329. struct intel_wait *wait)
  330. {
  331. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  332. struct rb_node **p, *parent, *completed;
  333. bool first, armed;
  334. u32 seqno;
  335. GEM_BUG_ON(!wait->seqno);
  336. /* Insert the request into the retirement ordered list
  337. * of waiters by walking the rbtree. If we are the oldest
  338. * seqno in the tree (the first to be retired), then
  339. * set ourselves as the bottom-half.
  340. *
  341. * As we descend the tree, prune completed branches since we hold the
  342. * spinlock we know that the first_waiter must be delayed and can
  343. * reduce some of the sequential wake up latency if we take action
  344. * ourselves and wake up the completed tasks in parallel. Also, by
  345. * removing stale elements in the tree, we may be able to reduce the
  346. * ping-pong between the old bottom-half and ourselves as first-waiter.
  347. */
  348. armed = false;
  349. first = true;
  350. parent = NULL;
  351. completed = NULL;
  352. seqno = intel_engine_get_seqno(engine);
  353. /* If the request completed before we managed to grab the spinlock,
  354. * return now before adding ourselves to the rbtree. We let the
  355. * current bottom-half handle any pending wakeups and instead
  356. * try and get out of the way quickly.
  357. */
  358. if (i915_seqno_passed(seqno, wait->seqno)) {
  359. RB_CLEAR_NODE(&wait->node);
  360. return first;
  361. }
  362. p = &b->waiters.rb_node;
  363. while (*p) {
  364. parent = *p;
  365. if (wait->seqno == to_wait(parent)->seqno) {
  366. /* We have multiple waiters on the same seqno, select
  367. * the highest priority task (that with the smallest
  368. * task->prio) to serve as the bottom-half for this
  369. * group.
  370. */
  371. if (wait->tsk->prio > to_wait(parent)->tsk->prio) {
  372. p = &parent->rb_right;
  373. first = false;
  374. } else {
  375. p = &parent->rb_left;
  376. }
  377. } else if (i915_seqno_passed(wait->seqno,
  378. to_wait(parent)->seqno)) {
  379. p = &parent->rb_right;
  380. if (i915_seqno_passed(seqno, to_wait(parent)->seqno))
  381. completed = parent;
  382. else
  383. first = false;
  384. } else {
  385. p = &parent->rb_left;
  386. }
  387. }
  388. rb_link_node(&wait->node, parent, p);
  389. rb_insert_color(&wait->node, &b->waiters);
  390. if (first) {
  391. spin_lock(&b->irq_lock);
  392. b->irq_wait = wait;
  393. /* After assigning ourselves as the new bottom-half, we must
  394. * perform a cursory check to prevent a missed interrupt.
  395. * Either we miss the interrupt whilst programming the hardware,
  396. * or if there was a previous waiter (for a later seqno) they
  397. * may be woken instead of us (due to the inherent race
  398. * in the unlocked read of b->irq_seqno_bh in the irq handler)
  399. * and so we miss the wake up.
  400. */
  401. armed = __intel_breadcrumbs_enable_irq(b);
  402. spin_unlock(&b->irq_lock);
  403. }
  404. if (completed) {
  405. /* Advance the bottom-half (b->irq_wait) before we wake up
  406. * the waiters who may scribble over their intel_wait
  407. * just as the interrupt handler is dereferencing it via
  408. * b->irq_wait.
  409. */
  410. if (!first) {
  411. struct rb_node *next = rb_next(completed);
  412. GEM_BUG_ON(next == &wait->node);
  413. __intel_breadcrumbs_next(engine, next);
  414. }
  415. do {
  416. struct intel_wait *crumb = to_wait(completed);
  417. completed = rb_prev(completed);
  418. __intel_breadcrumbs_finish(b, crumb);
  419. } while (completed);
  420. }
  421. GEM_BUG_ON(!b->irq_wait);
  422. GEM_BUG_ON(!b->irq_armed);
  423. GEM_BUG_ON(rb_first(&b->waiters) != &b->irq_wait->node);
  424. return armed;
  425. }
  426. bool intel_engine_add_wait(struct intel_engine_cs *engine,
  427. struct intel_wait *wait)
  428. {
  429. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  430. bool armed;
  431. spin_lock_irq(&b->rb_lock);
  432. armed = __intel_engine_add_wait(engine, wait);
  433. spin_unlock_irq(&b->rb_lock);
  434. if (armed)
  435. return armed;
  436. /* Make the caller recheck if its request has already started. */
  437. return i915_seqno_passed(intel_engine_get_seqno(engine),
  438. wait->seqno - 1);
  439. }
  440. static inline bool chain_wakeup(struct rb_node *rb, int priority)
  441. {
  442. return rb && to_wait(rb)->tsk->prio <= priority;
  443. }
  444. static inline int wakeup_priority(struct intel_breadcrumbs *b,
  445. struct task_struct *tsk)
  446. {
  447. if (tsk == b->signaler)
  448. return INT_MIN;
  449. else
  450. return tsk->prio;
  451. }
  452. static void __intel_engine_remove_wait(struct intel_engine_cs *engine,
  453. struct intel_wait *wait)
  454. {
  455. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  456. lockdep_assert_held(&b->rb_lock);
  457. if (RB_EMPTY_NODE(&wait->node))
  458. goto out;
  459. if (b->irq_wait == wait) {
  460. const int priority = wakeup_priority(b, wait->tsk);
  461. struct rb_node *next;
  462. /* We are the current bottom-half. Find the next candidate,
  463. * the first waiter in the queue on the remaining oldest
  464. * request. As multiple seqnos may complete in the time it
  465. * takes us to wake up and find the next waiter, we have to
  466. * wake up that waiter for it to perform its own coherent
  467. * completion check.
  468. */
  469. next = rb_next(&wait->node);
  470. if (chain_wakeup(next, priority)) {
  471. /* If the next waiter is already complete,
  472. * wake it up and continue onto the next waiter. So
  473. * if have a small herd, they will wake up in parallel
  474. * rather than sequentially, which should reduce
  475. * the overall latency in waking all the completed
  476. * clients.
  477. *
  478. * However, waking up a chain adds extra latency to
  479. * the first_waiter. This is undesirable if that
  480. * waiter is a high priority task.
  481. */
  482. u32 seqno = intel_engine_get_seqno(engine);
  483. while (i915_seqno_passed(seqno, to_wait(next)->seqno)) {
  484. struct rb_node *n = rb_next(next);
  485. __intel_breadcrumbs_finish(b, to_wait(next));
  486. next = n;
  487. if (!chain_wakeup(next, priority))
  488. break;
  489. }
  490. }
  491. __intel_breadcrumbs_next(engine, next);
  492. } else {
  493. GEM_BUG_ON(rb_first(&b->waiters) == &wait->node);
  494. }
  495. GEM_BUG_ON(RB_EMPTY_NODE(&wait->node));
  496. rb_erase(&wait->node, &b->waiters);
  497. RB_CLEAR_NODE(&wait->node);
  498. out:
  499. GEM_BUG_ON(b->irq_wait == wait);
  500. GEM_BUG_ON(rb_first(&b->waiters) !=
  501. (b->irq_wait ? &b->irq_wait->node : NULL));
  502. }
  503. void intel_engine_remove_wait(struct intel_engine_cs *engine,
  504. struct intel_wait *wait)
  505. {
  506. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  507. /* Quick check to see if this waiter was already decoupled from
  508. * the tree by the bottom-half to avoid contention on the spinlock
  509. * by the herd.
  510. */
  511. if (RB_EMPTY_NODE(&wait->node)) {
  512. GEM_BUG_ON(READ_ONCE(b->irq_wait) == wait);
  513. return;
  514. }
  515. spin_lock_irq(&b->rb_lock);
  516. __intel_engine_remove_wait(engine, wait);
  517. spin_unlock_irq(&b->rb_lock);
  518. }
  519. static void signaler_set_rtpriority(void)
  520. {
  521. struct sched_param param = { .sched_priority = 1 };
  522. sched_setscheduler_nocheck(current, SCHED_FIFO, &param);
  523. }
  524. static int intel_breadcrumbs_signaler(void *arg)
  525. {
  526. struct intel_engine_cs *engine = arg;
  527. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  528. struct i915_request *rq, *n;
  529. /* Install ourselves with high priority to reduce signalling latency */
  530. signaler_set_rtpriority();
  531. do {
  532. bool do_schedule = true;
  533. LIST_HEAD(list);
  534. u32 seqno;
  535. set_current_state(TASK_INTERRUPTIBLE);
  536. if (list_empty(&b->signals))
  537. goto sleep;
  538. /*
  539. * We are either woken up by the interrupt bottom-half,
  540. * or by a client adding a new signaller. In both cases,
  541. * the GPU seqno may have advanced beyond our oldest signal.
  542. * If it has, propagate the signal, remove the waiter and
  543. * check again with the next oldest signal. Otherwise we
  544. * need to wait for a new interrupt from the GPU or for
  545. * a new client.
  546. */
  547. seqno = intel_engine_get_seqno(engine);
  548. spin_lock_irq(&b->rb_lock);
  549. list_for_each_entry_safe(rq, n, &b->signals, signaling.link) {
  550. u32 this = rq->signaling.wait.seqno;
  551. GEM_BUG_ON(!rq->signaling.wait.seqno);
  552. if (!i915_seqno_passed(seqno, this))
  553. break;
  554. if (likely(this == i915_request_global_seqno(rq))) {
  555. __intel_engine_remove_wait(engine,
  556. &rq->signaling.wait);
  557. rq->signaling.wait.seqno = 0;
  558. __list_del_entry(&rq->signaling.link);
  559. if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
  560. &rq->fence.flags)) {
  561. list_add_tail(&rq->signaling.link,
  562. &list);
  563. i915_request_get(rq);
  564. }
  565. }
  566. }
  567. spin_unlock_irq(&b->rb_lock);
  568. if (!list_empty(&list)) {
  569. local_bh_disable();
  570. list_for_each_entry_safe(rq, n, &list, signaling.link) {
  571. dma_fence_signal(&rq->fence);
  572. GEM_BUG_ON(!i915_request_completed(rq));
  573. i915_request_put(rq);
  574. }
  575. local_bh_enable(); /* kick start the tasklets */
  576. /*
  577. * If the engine is saturated we may be continually
  578. * processing completed requests. This angers the
  579. * NMI watchdog if we never let anything else
  580. * have access to the CPU. Let's pretend to be nice
  581. * and relinquish the CPU if we burn through the
  582. * entire RT timeslice!
  583. */
  584. do_schedule = need_resched();
  585. }
  586. if (unlikely(do_schedule)) {
  587. /* Before we sleep, check for a missed seqno */
  588. if (current->state & TASK_NORMAL &&
  589. !list_empty(&b->signals) &&
  590. engine->irq_seqno_barrier &&
  591. test_and_clear_bit(ENGINE_IRQ_BREADCRUMB,
  592. &engine->irq_posted)) {
  593. engine->irq_seqno_barrier(engine);
  594. intel_engine_wakeup(engine);
  595. }
  596. sleep:
  597. if (kthread_should_park())
  598. kthread_parkme();
  599. if (unlikely(kthread_should_stop()))
  600. break;
  601. schedule();
  602. }
  603. } while (1);
  604. __set_current_state(TASK_RUNNING);
  605. return 0;
  606. }
  607. static void insert_signal(struct intel_breadcrumbs *b,
  608. struct i915_request *request,
  609. const u32 seqno)
  610. {
  611. struct i915_request *iter;
  612. lockdep_assert_held(&b->rb_lock);
  613. /*
  614. * A reasonable assumption is that we are called to add signals
  615. * in sequence, as the requests are submitted for execution and
  616. * assigned a global_seqno. This will be the case for the majority
  617. * of internally generated signals (inter-engine signaling).
  618. *
  619. * Out of order waiters triggering random signaling enabling will
  620. * be more problematic, but hopefully rare enough and the list
  621. * small enough that the O(N) insertion sort is not an issue.
  622. */
  623. list_for_each_entry_reverse(iter, &b->signals, signaling.link)
  624. if (i915_seqno_passed(seqno, iter->signaling.wait.seqno))
  625. break;
  626. list_add(&request->signaling.link, &iter->signaling.link);
  627. }
  628. bool intel_engine_enable_signaling(struct i915_request *request, bool wakeup)
  629. {
  630. struct intel_engine_cs *engine = request->engine;
  631. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  632. struct intel_wait *wait = &request->signaling.wait;
  633. u32 seqno;
  634. /*
  635. * Note that we may be called from an interrupt handler on another
  636. * device (e.g. nouveau signaling a fence completion causing us
  637. * to submit a request, and so enable signaling). As such,
  638. * we need to make sure that all other users of b->rb_lock protect
  639. * against interrupts, i.e. use spin_lock_irqsave.
  640. */
  641. /* locked by dma_fence_enable_sw_signaling() (irqsafe fence->lock) */
  642. GEM_BUG_ON(!irqs_disabled());
  643. lockdep_assert_held(&request->lock);
  644. seqno = i915_request_global_seqno(request);
  645. if (!seqno) /* will be enabled later upon execution */
  646. return true;
  647. GEM_BUG_ON(wait->seqno);
  648. wait->tsk = b->signaler;
  649. wait->request = request;
  650. wait->seqno = seqno;
  651. /*
  652. * Add ourselves into the list of waiters, but registering our
  653. * bottom-half as the signaller thread. As per usual, only the oldest
  654. * waiter (not just signaller) is tasked as the bottom-half waking
  655. * up all completed waiters after the user interrupt.
  656. *
  657. * If we are the oldest waiter, enable the irq (after which we
  658. * must double check that the seqno did not complete).
  659. */
  660. spin_lock(&b->rb_lock);
  661. insert_signal(b, request, seqno);
  662. wakeup &= __intel_engine_add_wait(engine, wait);
  663. spin_unlock(&b->rb_lock);
  664. if (wakeup) {
  665. wake_up_process(b->signaler);
  666. return !intel_wait_complete(wait);
  667. }
  668. return true;
  669. }
  670. void intel_engine_cancel_signaling(struct i915_request *request)
  671. {
  672. struct intel_engine_cs *engine = request->engine;
  673. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  674. GEM_BUG_ON(!irqs_disabled());
  675. lockdep_assert_held(&request->lock);
  676. if (!READ_ONCE(request->signaling.wait.seqno))
  677. return;
  678. spin_lock(&b->rb_lock);
  679. __intel_engine_remove_wait(engine, &request->signaling.wait);
  680. if (fetch_and_zero(&request->signaling.wait.seqno))
  681. __list_del_entry(&request->signaling.link);
  682. spin_unlock(&b->rb_lock);
  683. }
  684. int intel_engine_init_breadcrumbs(struct intel_engine_cs *engine)
  685. {
  686. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  687. struct task_struct *tsk;
  688. spin_lock_init(&b->rb_lock);
  689. spin_lock_init(&b->irq_lock);
  690. timer_setup(&b->fake_irq, intel_breadcrumbs_fake_irq, 0);
  691. timer_setup(&b->hangcheck, intel_breadcrumbs_hangcheck, 0);
  692. INIT_LIST_HEAD(&b->signals);
  693. /* Spawn a thread to provide a common bottom-half for all signals.
  694. * As this is an asynchronous interface we cannot steal the current
  695. * task for handling the bottom-half to the user interrupt, therefore
  696. * we create a thread to do the coherent seqno dance after the
  697. * interrupt and then signal the waitqueue (via the dma-buf/fence).
  698. */
  699. tsk = kthread_run(intel_breadcrumbs_signaler, engine,
  700. "i915/signal:%d", engine->id);
  701. if (IS_ERR(tsk))
  702. return PTR_ERR(tsk);
  703. b->signaler = tsk;
  704. return 0;
  705. }
  706. static void cancel_fake_irq(struct intel_engine_cs *engine)
  707. {
  708. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  709. del_timer_sync(&b->fake_irq); /* may queue b->hangcheck */
  710. del_timer_sync(&b->hangcheck);
  711. clear_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings);
  712. }
  713. void intel_engine_reset_breadcrumbs(struct intel_engine_cs *engine)
  714. {
  715. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  716. unsigned long flags;
  717. spin_lock_irqsave(&b->irq_lock, flags);
  718. /*
  719. * Leave the fake_irq timer enabled (if it is running), but clear the
  720. * bit so that it turns itself off on its next wake up and goes back
  721. * to the long hangcheck interval if still required.
  722. */
  723. clear_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings);
  724. if (b->irq_enabled)
  725. irq_enable(engine);
  726. else
  727. irq_disable(engine);
  728. /*
  729. * We set the IRQ_BREADCRUMB bit when we enable the irq presuming the
  730. * GPU is active and may have already executed the MI_USER_INTERRUPT
  731. * before the CPU is ready to receive. However, the engine is currently
  732. * idle (we haven't started it yet), there is no possibility for a
  733. * missed interrupt as we enabled the irq and so we can clear the
  734. * immediate wakeup (until a real interrupt arrives for the waiter).
  735. */
  736. clear_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted);
  737. spin_unlock_irqrestore(&b->irq_lock, flags);
  738. }
  739. void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine)
  740. {
  741. struct intel_breadcrumbs *b = &engine->breadcrumbs;
  742. /* The engines should be idle and all requests accounted for! */
  743. WARN_ON(READ_ONCE(b->irq_wait));
  744. WARN_ON(!RB_EMPTY_ROOT(&b->waiters));
  745. WARN_ON(!list_empty(&b->signals));
  746. if (!IS_ERR_OR_NULL(b->signaler))
  747. kthread_stop(b->signaler);
  748. cancel_fake_irq(engine);
  749. }
  750. #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
  751. #include "selftests/intel_breadcrumbs.c"
  752. #endif